Follow

Keep Up to Date with the Most Important News

By pressing the Subscribe button, you confirm that you have read and are agreeing to our Privacy Policy and Terms of Use
Contact

Argument passed in must be a string of 12 bytes

Hello guys i’m getting this message when i’m trying to delete an entry in my DB.
I have tried JSON.parse on the req.body,switched the routes in my routes file yet nothing seems to work.

this is my controller :

async function removeToy(req, res) {
  try {
    const { toyId } = req.params
    const removedId = await toyService.remove(toyId)
    res.send(removedId)
  } catch (err) {
    logger.error('Failed to remove toy', err)
    res.status(500).send({ err: 'Failed to remove toy' })
  }
}

this is the service :

MEDevel.com: Open-source for Healthcare and Education

Collecting and validating open-source software for healthcare, education, enterprise, development, medical imaging, medical records, and digital pathology.

Visit Medevel

async function remove(toyId) {

  try {
      const collection = await dbService.getCollection('toy')
      await collection.deleteOne({ '_id': ObjectId(toyId)})
      return toyId
  } catch (err) {
      logger.error(`cannot remove toy ${toyId}`, err)
      throw err
  }
}

also added a picture of how the DB looks like:
enter image description here

and the picture of the entire error :
enter image description here

appreciating any kind of help!

>Solution :

In your database you have an object whose _id is of type string.

In your query, you’re casting (presumably) a string to an ObjectID, which is an object. Not only is the argument you’re passing to ObjectId() not something that it supports (as the error indicates, see below), even if it would be valid, the query would result in 0 hits: after all "TZ23c" !== ObjectId("TZ23c").

Simply change .deleteOne({_id: ObjectId(toyId)}) to .deleteOne({_id: toyId}).

ObjectId() either takes no argument (it will return a new value) or it takes exactly 12 bytes (24 hexadecimal characters), for example: ObjectId("61e16f21f82a9db6a2094e78").

An ObjectId’s string representation (ObjectId().toString()) is not an arbitrary string of characters: it’s a timestamp, some values that identify which server generated it and some random values to prevent collisions. Not every string is a valid ObjectId.

Add a comment

Leave a Reply

Keep Up to Date with the Most Important News

By pressing the Subscribe button, you confirm that you have read and are agreeing to our Privacy Policy and Terms of Use

Discover more from Dev solutions

Subscribe now to keep reading and get access to the full archive.

Continue reading