Quick question, would I need to unsubscribe the subscription contained here since it’s not in the constructor?
import { Component, OnInit } from '@angular/core';
import { HttpService } from "./services/http.service";
import { Main } from "./interfaces/data-interface";
@Component({
selector: 'app-root',
templateUrl: './app.component.html',
styleUrls: ['./app.component.scss']
})
export class AppComponent implements OnInit {
constructor(private httpService: HttpService) {
}
mainData: Main;
itemIndexFocus: number = 0;
ngOnInit() {
this.httpService.getFighterDetail()
.subscribe((res) => {
this.mainData = res.body;
console.log(this.mainData);
});
}
getImage() {
return this.mainData.matches[this.itemIndexFocus].image;
}
}
The httpservice file looks like this:
import { Injectable } from '@angular/core';
import { HttpClient, HttpHeaders } from "@angular/common/http";
import { Observable } from 'rxjs';
@Injectable()
export class HttpService {
constructor(private http: HttpClient) { }
getFighterDetail(): Observable<any> {
return this.http.get("/MYAPI", { responseType: 'json', observe: 'response' })
}
}
>Solution :
No you don’t.
HttpClient is ‘fire once’ and it automatically unsubscribes after that.
As your service wraps HttpClient you don’t need to unsubscribe either.
Note it’s nothing do so with whether it is declared in the constructor or not, rather amor the characteristics of the underlying observable.