This PR was created in response to an issue I made. I don’t have write access to this repo. The PR has already been merged into the main branch, but I’d like to suggest a change anyway; here’s one of the modifications in that PR:
- { index: 3, text: 'I would like some gelb bananen bitte', value: 100 },
- { index: 4, text: 'I hope batch update is working', value: 300 },
+ { Rank: 3, text: 'I would like some Yellow', value: 100 },
+ { Rank: 4, text: 'I hope batch update is working', value: 300 },
I’d like to suggest this change in casing (Rank to rank):
- { Rank: 3, text: 'I would like some Yellow', value: 100 },
- { Rank: 4, text: 'I hope batch update is working', value: 300 },
+ { rank: 3, text: 'I would like some Yellow', value: 100 },
+ { rank: 4, text: 'I hope batch update is working', value: 300 },
But when I click on the + button to submit a comment, I don’t see the "Suggest Change" button described in the official documentation (see step 6):
This is what my editor looks like:
I don’t have a lot of experience with GitHub Pull Requests. For all I know:
- This is working as intended because of some sort of repository setting.
- This is working as intended because you can’t modify a PR after it’s been merged? I know git can merge from one branch to another multiple times, but I also know PR !==
git merge: this may be irrelevant. - This is a GitHub bug. I found other GitHub users reporting the same problem, but that’s in a community post without an official response, and despite the comments, I think this is a feature request, not a bug report. But—and I say this with all due respect—those users may think they are experiencing a bug but the site is working as intended.
Many of those comments say the suggestion feature still works even though the button is missing. That’s part of their complaint: they have to manually type "“`suggestion" into the editor.
>Solution :
You can’t do that on a merged Pull Request. What you can do instead is fork the repository, make the change on your fork, and open a new Pull Request.
I did some experimentation on a repository, and the rule seems to be that you can only create or apply suggested changes on a Pull Request which is open, and not merged or closed.
This is what the suggested change button looks like after creating a new pull request:
Then, after the pull request is closed:
After the PR is reopened:
And this is what it looks like after merging the PR:
This shows that the thing preventing you from making suggested changes is the PR status. Since you can’t re-open a merged pull request, you can’t make a suggested change on this PR.
Even if you could make the suggestion, the button for applying the change is greyed out when the PR is closed or merged.
The best you can do is make a new Pull Request.